ignore empty tx in GetDiffAccountsWithScope #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keefe-Liu <bianze.kernel@gmail.com>
unclezoro
approved these changes
Oct 11, 2021
yutianwu
approved these changes
Oct 11, 2021
This was referenced Oct 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Keefe-Liu bianze.kernel@gmail.com
Description
Ignore empty transaction in GetDiffAccountsWithScope.
Rationale
The empty transaction is useless for user, ignore them to reduce iteration.
Example
Changes
Notable changes:
Preflight checks
make build)make test)Already reviewed by
...
Related issues
... reference related issue #'s here ...