[R4R] skip verification on account storage root to tolerate with fastnode when doing diffsync #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
force-pushed
the
skip_storage_root_check
branch
from
f28654e
to
8f659a9
Compare
unclezoro
changed the title
yutianwu
approved these changes
Mar 24, 2022
j75689
approved these changes
Mar 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The developer proposes a fast node in these PR #640.
And the fast node is adopted by many developers, there is some adaptive work to do to make fast node serve diffsync well.
Rationale
A fast node is a node without MPT(Merkle Patricia Tries, which means the account inside the generated difflayer will not have the correct
storageRoot.Currently, diffsync will check the calculated
storageRootof each account against thestorageRootwithin the untrusted difflaayer. While this is not necessary to guarantee the correctness of each account, since diffsync will verify the state root of the biggest account MPT, which already guarantees the data consistency. We will remove the redundant check in this PR to be compatible with fast node.Example
No API changes.
Changes
No