feat: added vote collector, refactored broadcast #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Please check |
…ain/greenfield-challenger into feat/refactor-collector-broadcast
submitter/tx_submitter.go
Outdated
| @@ -34,119 +36,108 @@ func NewTxSubmitter(cfg *config.Config, executor *executor.Executor, daoManager | |||
| } | |||
|
|
|||
| func (s *TxSubmitter) SubmitTransactionLoop() { | |||
| s.cachedEventHash = make(map[uint64][]byte, math.MaxInt) | |||
| submitAttempt := 0 | |||
There was a problem hiding this comment.
As we discussed, the logic will change a bit after the in-turn challenger on chain.
| "strings" | ||
| "sync" | ||
| "time" | ||
|
|
||
| "github.com/panjf2000/ants/v2" |
There was a problem hiding this comment.
There are some TODO: revert in this file. Could you check and fix them?
vote/data_provider.go
Outdated
| func (h *DataHandler) FetchEventsForSelfVote() ([]*model.Event, error) { | ||
| events, err := h.daoManager.GetEarliestEventsByStatusAndAfter(model.Verified, batchSize, h.lastIdForSelfVote) | ||
| func (h *DataHandler) FetchEventsForSelfVote(currentHeight uint64) ([]*model.Event, error) { | ||
| // TODO: Revert this |
There was a problem hiding this comment.
Please check this.
| voteBroadcaster: voteBroadcaster, | ||
| voteCollator: voteCollator, | ||
| txSubmitter: txSubmitter, | ||
| dbWiper: dbWiper, |
There was a problem hiding this comment.
Do we need wiper? Sometimes we need to review or query historical data. We may not need it now.
forcodedancing
force-pushed
the
feat/refactor-collector-broadcast
branch
from
12e33b0
to
f819cd7
Compare
forcodedancing
force-pushed
the
feat/refactor-collector-broadcast
branch
from
f819cd7
to
6205763
Compare
This was referenced May 23, 2023
randyahx
added a commit
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added a vote collector that queries the blockchain for votes using eventhash and stores them for 2/3 consensus.
refactored broadcast to collate votes using eventhash instead of challengeid, broadcast votes periodically until expired height
refactored broadcaster, collator, submitter to use for loop instead of goroutine to solve performance issues
refactored workflow for collector, broadcaster, collator, submitter
added db wiper to periodically clear db
Rationale
services could not sync their votes to submit a msgattest
Example
none
Changes
Notable changes:
vote collector
vote broadcast
models, dao
data providers