fix: fix bucket and object API doc #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgao001
reviewed
Sep 21, 2023
client/api_bucket.go
Outdated
| @@ -184,7 +191,17 @@ func (c *Client) CreateBucket(ctx context.Context, bucketName string, primaryAdd | |||
| return txnHash, nil | |||
| } | |||
|
|
|||
| // DeleteBucket send DeleteBucket txn to greenfield chain and return txn hash | |||
| // DeleteBucket - Sends DeleteBucket msg to greenfield chain and return txn hash. | |||
KeefeL
approved these changes
Sep 21, 2023
KeefeL
pushed a commit
that referenced
this pull request
Sep 21, 2023
* docs: refine the comments of bucket api * docs: update metadata list apis and option.go * doc: improve the comments of bucket api * fix: fix the object api comments * fix: fix the object interface --------- Co-authored-by: BarryTong65 <barrytong.work@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 21, 2023
* docs: refactor for adding comments * docs: refine Basic, Group, SP, VG Clients and types.go documentation. (#184) * doc: refactor for adding comments * Refine Basic, Group, SP, VG, and types.go documentation. * fix format * enrich comments --------- Co-authored-by: Keefe Liu <keefe.l@users.noreply.github.com> * docs: refine the go doc of the cross-chain related apis (#187) * docs: refine the go doc of the cross-chain related apis * fix comment * docs: refine the go doc of payment apis (#185) * doc: refine the go doc of payment apis * doc: refine the go doc of payment apis * fix review comments * docs: refine the go doc of validator/staking apis (#186) * docs: refine the go doc of validator/staking apis * fix review comments * fix: fix bucket and object API doc (#189) * docs: refine the comments of bucket api * docs: update metadata list apis and option.go * doc: improve the comments of bucket api * fix: fix the object api comments * fix: fix the object interface --------- Co-authored-by: BarryTong65 <barrytong.work@gmail.com> * fix: go-sdk doc for off chain auth (#190) * fix: go-sdk doc for off chain auth * fix: go-sdk doc for off chain auth - adding input description. --------- Co-authored-by: Clyde <clyde.m@nodereal.io> * docs: refine the go doc of challenge apis (#183) * doc: refine the go doc of challenge apis * doc: refine the go doc of challenge apis * fix review comments --------- Co-authored-by: Keefe Liu <keefe.l@users.noreply.github.com> * fix: fix e2e (#192) * docs: add comments for the account file * fix: fix list.go comment (#194) * fix: fix list.go comment (#197) * fix: fix group api (#198) --------- Co-authored-by: Keefe Liu <keefe.l@users.noreply.github.com> Co-authored-by: Alexxxxxx <118710506+alexgao001@users.noreply.github.com> Co-authored-by: yutianwu <wzxingbupt@gmail.com> Co-authored-by: forcodedancing <just.haha.it@gmail.com> Co-authored-by: flywukong <2229306838@qq.com> Co-authored-by: BarryTong65 <barrytong.work@gmail.com> Co-authored-by: ruojunm <46366167+ruojunm@users.noreply.github.com> Co-authored-by: Clyde <clyde.m@nodereal.io> Co-authored-by: Barry <122767193+BarryTong65@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix bucket and object API doc
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: