feat: list groups by ids #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flywukong
reviewed
Sep 21, 2023
client/api_group.go
Outdated
| Value *types.GroupMeta | ||
| } | ||
|
|
||
| func (m *GfSpListGroupsByGroupIDsResponse) UnmarshalXML(d *xml.Decoder, start xml.StartElement) error { |
client/api_group.go
Outdated
| @@ -74,6 +74,8 @@ type Group interface { | |||
| // ListGroupsByOwner returns a list of groups owned by the specified user, including those for which the user's expiration time has already elapsed | |||
| // By default, the user is the sender. Other users can be set using the option | |||
| ListGroupsByOwner(ctx context.Context, opts types.GroupsOwnerPaginationOptions) (*types.GroupsResult, error) | |||
| // ListGroupsByGroupID list groups by group ids | |||
client/api_group.go
Outdated
|
|
||
| type GfSpListGroupsByGroupIDsResponse map[uint64]*types.GroupMeta | ||
|
|
||
| type GroupEntry struct { |
There was a problem hiding this comment.
No need to expose these fields to the user, please start with lowercase letters.
KeefeL
reviewed
Sep 21, 2023
client/api_group.go
Outdated
| @@ -568,3 +570,106 @@ func (c *client) ListGroupsByOwner(ctx context.Context, opts types.GroupsOwnerPa | |||
|
|
|||
| return groups, nil | |||
| } | |||
|
|
|||
| type GfSpListGroupsByGroupIDsResponse map[uint64]*types.GroupMeta | |||
There was a problem hiding this comment.
No need to expose these fields to the user, please start with lowercase letters.
flywukong
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support list groups by ids
update payment account info in list user payment account
Rationale
N/A
Example
N/A
Changes
Notable changes: