fix: release all sp from freeze pool if there is no way to create new…

… GVG to serve (#1424)

base/gfspvgmgr/virtual_group_manager.go

@@ -529,6 +529,10 @@ func (vgm *virtualGroupManager) FreezeSPAndGVGs(spID uint32, gvgs []*virtualgrou
 	vgm.freezeSPPool.FreezeSPAndGVGs(spID, gvgs)
 }
 
+func (vgm *virtualGroupManager) ReleaseAllSP() {
+	vgm.freezeSPPool.ReleaseAllSP()
+}
+
 // releaseSPAndGVGLoop runs periodically to release SP from the freeze pool
 func (vgm *virtualGroupManager) releaseSPAndGVGLoop() {
 	ticker := time.NewTicker(ReleaseSPJobInterval)

core/vgmgr/virtual_group_manager.go

@@ -144,6 +144,9 @@ type VirtualGroupManager interface {
 	// For those SPs which are in the pool will be skipped when creating a GVG, GVGs in the pool will not be chosen to seal Object
 	// until released
 	FreezeSPAndGVGs(spID uint32, gvgs []*virtualgrouptypes.GlobalVirtualGroup)
+	// ReleaseAllSP release all sp and their related GVG, in case that there is no enough balance to create a new GVG.
+	// should use the exisiting GVG even it failed to serve previously.
+	ReleaseAllSP()
 }
 
 // NewVirtualGroupManager is the virtual group manager init api.

modular/manager/manage_task.go

@@ -145,6 +145,8 @@ func (m *ManageModular) pickGVGAndReplicate(ctx context.Context, vgfID uint32, t
 	gvgMeta, err := m.pickGlobalVirtualGroup(ctx, vgfID, task.GetStorageParams())
 	log.CtxInfow(ctx, "pick global virtual group", "time_cost", time.Since(startPickGVGTime).Seconds(), "gvg_meta", gvgMeta, "error", err)
 	if err != nil {
+		// If there is no way to create a new GVG, release all sp from freeze Pool, better than not serving requests.
+		m.virtualGroupManager.ReleaseAllSP()
 		return err
 	}
 	replicateTask := &gfsptask.GfSpReplicatePieceTask{}