fix: add challenge v2 api to avoid piece hash http header too large #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-2012
force-pushed
the
fix-challenge-502
branch
from
a099851
to
e8a5845
Compare
will-2012
force-pushed
the
fix-challenge-502
branch
from
e8a5845
to
0e63696
Compare
sysvm
reviewed
Oct 18, 2023
modular/gater/admin_handler.go
Outdated
| @@ -377,6 +378,169 @@ func (g *GateModular) getChallengeInfoHandler(w http.ResponseWriter, r *http.Req | |||
| log.CtxDebug(reqCtx.Context(), "succeed to get challenge info") | |||
| } | |||
|
|
|||
| // getChallengeInfoV2Handler handles get challenge piece info request. Current only greenfield | |||
| // validator can challenge piece is store correctly. The challenge piece info includes: | |||
There was a problem hiding this comment.
Currently, only greenfield validator can challenge piece whether is stored correctly. is better.
sysvm
reviewed
Oct 18, 2023
modular/gater/admin_handler.go
Outdated
| // validator can challenge piece is store correctly. The challenge piece info includes: | ||
| // the challenged piece data, all piece hashes and the integrity hash. The challenger | ||
| // can verify the info whether are correct by comparing with the greenfield info. | ||
| // The difference between the v2 interface and the old interface is the format of the returned results, |
There was a problem hiding this comment.
Maybe the old interface(v1) is better.
will-2012
force-pushed
the
fix-challenge-502
branch
from
0e63696
to
0108ba3
Compare
will-2012
force-pushed
the
fix-challenge-502
branch
from
0108ba3
to
61b9d1f
Compare
will-2012
force-pushed
the
fix-challenge-502
branch
from
61b9d1f
to
cb28003
Compare
forcodedancing
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add challenge v2 API to avoid piece hash HTTP header too large.
Rationale
Components such as nginx can disconnect because the response header is too large, and users receive a 502 HTTP status code.
Example
N/A.
Changes
Notable changes: