feat: add golang runtime metrics, process metrics and std lib db metrics #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysvm
changed the title
sysvm
changed the title
sysvm
force-pushed
the
feat-golangmetrics
branch
from
291cc12
to
7d66857
Compare
jingjunLi
reviewed
Oct 30, 2023
base/gfspapp/app_options.go
Outdated
| @@ -256,6 +256,13 @@ func DefaultGfSpDBOption(app *GfSpBaseApp, cfg *gfspconfig.GfSpConfig) error { | |||
| return | |||
| } | |||
| app.gfSpDB = db | |||
There was a problem hiding this comment.
Should we place app.gfSpDB = db at the end of the function because db may be modified by RegisterStdDBStats?
There was a problem hiding this comment.
db is not modified by RegisterStdDBStats, this function is just used to get some db metrics.
will-2012
reviewed
Oct 30, 2023
pkg/metrics/metric_items.go
Outdated
| // golang runtime and process metrics | ||
| collectors.NewGoCollector(collectors.WithGoCollectorRuntimeMetrics(collectors.GoRuntimeMetricsRule{ | ||
| Matcher: regexp.MustCompile("/.*")})), | ||
| collectors.NewProcessCollector(collectors.ProcessCollectorOpts{}), |
There was a problem hiding this comment.
Keep consistent with the above, define a variable.
will-2012
approved these changes
Oct 30, 2023
jingjunLi
approved these changes
Oct 31, 2023
constwz
pushed a commit
that referenced
this pull request
Oct 31, 2023
…ics (#1197) * feat: add golang runtime metrics, process metrics and std lib db metrics * fix: define golang runtime and process metrics as variables --------- Co-authored-by: VM <arimas@foxmail.com>
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add golang runtime metrics, process metrics and std lib db metrics to improve availability.
Rationale
Improve availability and speed to debug problems.
Example
curl http://localhost:24367/metricsChanges
Notable changes: