feat: signer module adds metrics for each rpc interface #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysvm
requested review from
ruojunm,
will-2012,
unclezoro and
KeefeL
as code owners
sysvm
force-pushed
the
fix-creategvgmetrics
branch
from
cd6962e
to
014c24f
Compare
will-2012
reviewed
Nov 3, 2023
| metrics.ReqTime.WithLabelValues(SignerFailureCreateGVG).Observe(time.Since(startTime).Seconds()) | ||
| } else { | ||
| metrics.ReqCounter.WithLabelValues(SignerSuccessCreateGVG).Inc() | ||
| metrics.ReqTime.WithLabelValues(SignerSuccessCreateGVG).Observe(time.Since(startTime).Seconds()) |
There was a problem hiding this comment.
Check other interfaces of the signer and add metrics together.
jingjunLi
approved these changes
Nov 3, 2023
sysvm
changed the title
will-2012
approved these changes
Nov 3, 2023
base/gfspapp/app_options.go
Outdated
| SignerFailure = "signer_failure" | ||
| SignerSuccessBucketApproval = "signer_bucket_approval_success" | ||
| SignerFailureBucketApproval = "signer_bucket_approval_failure" | ||
| SignerSuccessMigrateBucketApproval = "signer_bucket_approval_success" |
base/gfspapp/app_options.go
Outdated
| SignerSuccessBucketApproval = "signer_bucket_approval_success" | ||
| SignerFailureBucketApproval = "signer_bucket_approval_failure" | ||
| SignerSuccessMigrateBucketApproval = "signer_bucket_approval_success" | ||
| SignerFailureMigrateBucketApproval = "signer_bucket_approval_failure" |
| @@ -73,6 +71,8 @@ func (e *ExecuteModular) HandleReplicatePieceTask(ctx context.Context, task core | |||
| sealErr := e.sealObject(ctx, task, sealMsg) | |||
| metrics.PerfPutObjectTime.WithLabelValues("background_seal_object_cost").Observe(time.Since(sealTime).Seconds()) | |||
| metrics.PerfPutObjectTime.WithLabelValues("background_task_seal_object_end").Observe(time.Since(startReplicateTime).Seconds()) | |||
| metrics.PerfPutObjectTime.WithLabelValues("object_throughout_all_process").Observe(time.Since( | |||
| time.Unix(task.GetObjectInfo().GetCreateAt(), 0)).Seconds()) | |||
There was a problem hiding this comment.
Also need to add in HandleSealObjectTask.
sysvm
force-pushed
the
fix-creategvgmetrics
branch
from
5ad57ae
to
7c98235
Compare
sysvm
force-pushed
the
fix-creategvgmetrics
branch
from
7c98235
to
cfc7f75
Compare
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Signer module adds metrics for each rpc interface.
Rationale
N/A
Example
N/A
Changes
Notable changes: