-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add task retry scheduler #1260
Conversation
de35deb
to
3c69f32
Compare
f151dc5
to
932b151
Compare
932b151
to
2095a8d
Compare
@@ -4,6 +4,9 @@ import ( | |||
"context" | |||
"encoding/hex" | |||
"errors" | |||
"strings" | |||
"testing" | |||
"time" | |||
|
|||
sdkmath "cosmossdk.io/math" | |||
"github.com/bnb-chain/greenfield-storage-provider/base/gfspapp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort imported pkgs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@@ -21,10 +24,6 @@ import ( | |||
|
|||
"google.golang.org/grpc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
modular/manager/manage_task.go
Outdated
@@ -10,6 +10,7 @@ import ( | |||
"time" | |||
|
|||
"cosmossdk.io/math" | |||
virtualgrouptypes "github.com/bnb-chain/greenfield/x/virtualgroup/types" | |||
sdk "github.com/cosmos/cosmos-sdk/types" | |||
"golang.org/x/exp/slices" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Description
Rationale
The task retry scheduler scans the recent upload context and re-push upload context to the dispatcher. If a task has not been sealed for a long time, it will be reject-unsealed.
Example
The above options turn on the task retry scheduler.
Changes
Notable changes:
Potential Impacts