Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Tags in object/bucket/group #1263

Merged
merged 4 commits into from
Dec 7, 2023
Merged

feat: add Tags in object/bucket/group #1263

merged 4 commits into from
Dec 7, 2023

Conversation

ruojunm
Copy link
Collaborator

@ruojunm ruojunm commented Dec 6, 2023

Description

feat: add Tags in object/bucket/group

Rationale

In greenfield chain, it will support tags in object, bucket, group entities and it has a new event EventSetTag, which block_syncer needs to handle.

Example

N/A

Changes

Notable changes:

  • add tags columns for object/bucket/group tables
  • add a "general" module in block_syncer, which can handle those events may impact multiple entities.
  • add UTs

Potential Impacts

  • greenfield-go-sdk needs to be changed accordingly
  • greenfield-js-sdk needs to be changed accordingly

BarryTong98
BarryTong98 reviewed Dec 6, 2023
View reviewed changes
modular/blocksyncer/modules/bucket/bucket_handle.go Outdated
@@ -3,7 +3,7 @@ package bucket
import (
"context"
"errors"

"github.com/bnb-chain/greenfield-storage-provider/modular/blocksyncer/util"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format the imports

modular/blocksyncer/modules/general/general_handler.go Outdated Show resolved Hide resolved
modular/blocksyncer/modules/general/module.go Outdated Show resolved Hide resolved
modular/blocksyncer/modules/group/group_handler.go Outdated Show resolved Hide resolved
modular/blocksyncer/modules/object/object_handler.go Outdated Show resolved Hide resolved
modular/blocksyncer/util/util.go Outdated Show resolved Hide resolved
store/bsdb/bucket_schema.go Outdated Show resolved Hide resolved
store/bsdb/group_schema.go Outdated Show resolved Hide resolved
store/bsdb/object_schema.go Outdated Show resolved Hide resolved
will-2012
will-2012 reviewed Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@will-2012 will-2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please check the failed action which may be related to the dependent chain version.

@ruojunm ruojunm merged commit 714f05f into develop Dec 7, 2023
11 checks passed
@ruojunm ruojunm deleted the feat-add-tags branch December 7, 2023 04:49
This was referenced Dec 7, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annielz annielz annielz left review comments

@Pythonberg1997 Pythonberg1997 Pythonberg1997 approved these changes

@BarryTong98 BarryTong98 BarryTong98 approved these changes

@will-2012 will-2012 will-2012 approved these changes

@constwz constwz constwz approved these changes

@unclezoro unclezoro Awaiting requested review from unclezoro

@KeefeL KeefeL Awaiting requested review from KeefeL KeefeL is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ruojunm @Pythonberg1997 @BarryTong98 @annielz @will-2012 @constwz