Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sp monthly free quota #1351

Merged
merged 12 commits into from
Feb 27, 2024
Merged

feat: sp monthly free quota #1351

merged 12 commits into from
Feb 27, 2024

Conversation

constwz
Copy link
Contributor

@constwz constwz commented Feb 21, 2024

Description

sp offers free monthly quota

Rationale

for greenfield user growth

Example

Upload and download files for free

Changes

Notable changes:

  • add monthly free quota logic
  • traffic table add new rows (monthly_quota_size, monthly_free_quota_consumed_size)
  • quota subtracts priorities: chargeQuota > monthlyFreeQuota > freeQuota

Potential Impacts

  • download file interface

Copy link
Collaborator

@ruojunm ruojunm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, please add related UT.

modular/downloader/downloader_options.go Outdated Show resolved Hide resolved
modular/metadata/metadata_bucket_service.go Show resolved Hide resolved
Copy link
Collaborator

@ruojunm ruojunm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@flywukong flywukong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@constwz constwz merged commit 96f1695 into develop Feb 27, 2024
12 checks passed
@constwz constwz deleted the feat-monthly-quota branch February 27, 2024 03:32
@ruojunm ruojunm mentioned this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants