Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: agent upload #1353

Merged
merged 40 commits into from
Mar 14, 2024
Merged

feat: agent upload #1353

merged 40 commits into from
Mar 14, 2024

Conversation

constwz
Copy link
Contributor

@constwz constwz commented Mar 4, 2024

Description

Add the delegate upload interface. Users only need to upload objects in one step

Rationale

Simplify operations and reduce costs

Changes

Notable changes:

  • Added delegateResumablePutObjectRouterName and delegatePutObjectRouterName two interfaces
  • Merge create and seal into one step
  • The primary sp saves each piece hash for validation and seal

Potential Impacts

  • object upload

constwz and others added 15 commits January 22, 2024 18:36
@constwz
fix:change log confilct
11eee1b
@constwz
Merge branch 'develop' of github.com:bnb-chain/greenfield-storage-pro…
d4aca96 
…vider into develop
@constwz
Merge branch 'develop' of github.com:bnb-chain/greenfield-storage-pro…
9168ebd 
…vider into develop
@constwz
Merge branch 'develop' of github.com:bnb-chain/greenfield-storage-pro…
d3f7ffc 
…vider into develop
@constwz
Merge branch 'develop' of github.com:bnb-chain/greenfield-storage-pro…
d70d5f2 
…vider into develop
@constwz
Merge branch 'develop' of github.com:bnb-chain/greenfield-storage-pro…
5aea71b 
…vider into develop
@constwz
Merge branch 'develop' of github.com:bnb-chain/greenfield-storage-pro…
e794d47 
…vider into develop
@constwz
feat: agent upload
ea0c139
@constwz
perf: object handler
edda3c6
@constwz
feat: resumable upload object
8a3e247
@constwz
feat: modify router
46dc737
@alexgao001
feat: delegated update
726b801
@alexgao001
feat: delegated update
8affb62
@constwz
fix: resumable put
8f925c4
@constwz
fix: resumable put
9dcd9be
@constwz constwz force-pushed the feat-agent-upload branch 2 times, most recently from 4d24d10 to 1209117 Compare March 6, 2024 09:06
ruojunm
ruojunm reviewed Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@ruojunm ruojunm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, adding more comments on new methods or new logic will be appreciated.

base/gfspclient/approver.go Outdated Show resolved Hide resolved
modular/executor/execute_task.go Show resolved Hide resolved
modular/uploader/upload_task.go Show resolved Hide resolved
modular/gater/object_handler.go Show resolved Hide resolved
alexgao001
alexgao001 reviewed Mar 11, 2024
View reviewed changes
base/gfspapp/approval_server.go Outdated Show resolved Hide resolved
base/gfspclient/signer.go Outdated Show resolved Hide resolved
base/types/gfsptask/approval.go Outdated Show resolved Hide resolved
base/types/gfsptask/approval.go Outdated Show resolved Hide resolved
core/spdb/spdb.go Outdated Show resolved Hide resolved
modular/signer/signer_client.go Outdated Show resolved Hide resolved
modular/uploader/upload_task.go Show resolved Hide resolved
proto/base/types/gfsptask/task.proto Show resolved Hide resolved
modular/manager/task_retry_scheduler.go Show resolved Hide resolved
modular/manager/manager.go Show resolved Hide resolved
alexgao001
alexgao001 reviewed Mar 11, 2024
View reviewed changes
modular/gater/object_handler.go Outdated Show resolved Hide resolved
modular/gater/object_handler.go Outdated Show resolved Hide resolved
modular/gater/object_handler.go Outdated Show resolved Hide resolved
modular/gater/object_handler.go Outdated Show resolved Hide resolved
modular/gater/object_handler.go Outdated Show resolved Hide resolved
alexgao001
alexgao001 reviewed Mar 12, 2024
View reviewed changes
base/types/gfsptask/approval.go Outdated Show resolved Hide resolved
core/consensus/consensus.go Outdated Show resolved Hide resolved
modular/gater/object_handler.go Outdated Show resolved Hide resolved
modular/gater/object_handler.go Outdated Show resolved Hide resolved
modular/gater/object_handler.go Outdated Show resolved Hide resolved
modular/signer/signer_client.go Outdated Show resolved Hide resolved
modular/signer/signer_client.go Outdated Show resolved Hide resolved
modular/signer/signer_client.go Outdated Show resolved Hide resolved
modular/signer/signer_client.go Outdated Show resolved Hide resolved
modular/signer/signer_client.go Outdated Show resolved Hide resolved
alexgao001
alexgao001 reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@alexgao001 alexgao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure logs include useful details. it would help debugging.

base/gfspclient/signer.go Outdated Show resolved Hide resolved
base/types/gfsptask/approval.go Show resolved Hide resolved
core/task/task.go Outdated Show resolved Hide resolved
core/task/task.go Outdated Show resolved Hide resolved
modular/executor/execute_replicate.go Outdated Show resolved Hide resolved
modular/signer/signer_client.go Outdated Show resolved Hide resolved
modular/signer/signer_client.go Outdated Show resolved Hide resolved
modular/uploader/upload_task.go Outdated Show resolved Hide resolved
modular/uploader/upload_task.go Outdated Show resolved Hide resolved
modular/uploader/upload_task.go Outdated Show resolved Hide resolved
@constwz constwz merged commit a1ffb6c into develop Mar 14, 2024
12 checks passed
@constwz constwz deleted the feat-agent-upload branch March 14, 2024 06:25
@ruojunm ruojunm mentioned this pull request Apr 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruojunm ruojunm ruojunm approved these changes

@alexgao001 alexgao001 alexgao001 approved these changes

@will-2012 will-2012 Awaiting requested review from will-2012

@unclezoro unclezoro Awaiting requested review from unclezoro

@KeefeL KeefeL Awaiting requested review from KeefeL KeefeL is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@constwz @ruojunm @alexgao001