feat: add tx confirm func and create virtual group retry #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-2012
changed the title
fynnss
reviewed
Aug 8, 2023
| @@ -783,3 +787,70 @@ func (g *Gnfd) VerifyPutObjectPermission(ctx context.Context, account, bucket, o | |||
| } | |||
| return false, err | |||
| } | |||
|
|
|||
| // ConfirmTransaction is used to confirm whether the transaction is on the chain. | |||
| func (g *Gnfd) ConfirmTransaction(ctx context.Context, txHash string) (*sdk.TxResponse, error) { | |||
There was a problem hiding this comment.
It should have a timeout for retry.
There was a problem hiding this comment.
Currently, only retry once and there is a timeout in waitForNextBlock.
There was a problem hiding this comment.
Why only retry once? The transaction may be completed after several blocks
There was a problem hiding this comment.
Retrying once basically guarantees whether it is in the current block or the next block.
what is the suggestion here.
fynnss
approved these changes
Aug 8, 2023
jingjunLi
approved these changes
Aug 8, 2023
This was referenced Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tx confirm func and create virtual group retry.
Rationale
Send tx and query tx hash, in order to ensure the tx executed by chain.
Example
N/A.
Changes
Notable changes: