Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audit] Unnecessary re-computation of stored value #61

Closed
AnomalRoil opened this issue Oct 2, 2019 · 0 comments · Fixed by #62
Closed

[Audit] Unnecessary re-computation of stored value #61

AnomalRoil opened this issue Oct 2, 2019 · 0 comments · Fixed by #62
Labels

Comments

@AnomalRoil
Copy link

In the signing round 1, the value round.temp.point is stored, but in round 4 and in round 5, the bigGamma value and the RX, RY values respectively are re-computed from the round.temp.gamma value, instead of being retrieved from the round.temp.point variable from round 1.

Since this implies modular exponentiations, performances could be improved by using the stored value.

ackratos added a commit that referenced this issue Oct 8, 2019
ackratos added a commit that referenced this issue Oct 8, 2019
notatestuser pushed a commit that referenced this issue Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants