Skip to content

Commit

Permalink
Fix pylint/isort/black version incompatability
Browse files Browse the repository at this point in the history
See pylint-dev/pylint#3725

Additionally fixes the py3 intersphinx inventory url, which was throwing
an error, and explicitly adds pylint to the dev requirements.
  • Loading branch information
bnbalsamo committed Oct 12, 2020
1 parent dc8f26e commit efeca7a
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion {{ cookiecutter.project_name }}/docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,4 +175,4 @@


# Example configuration for intersphinx: refer to the Python standard library.
intersphinx_mapping = {'https://docs.python.org/': None}
intersphinx_mapping = {'https://docs.python.org/3/': None}
2 changes: 1 addition & 1 deletion {{ cookiecutter.project_name }}/docs/index.rst
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.. {{cookiecutter.project_name}} documentation master file, created by
sphinx-quickstart on Wed Jan 10 15:24:36 2018.
sphinx-quickstart.
You can adapt this file completely to your liking, but it should at least
contain the root `toctree` directive.
Expand Down
1 change: 0 additions & 1 deletion {{ cookiecutter.project_name }}/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ requires = ["setuptools>=40.6.0", "wheel"]
build-backend = "setuptools.build_meta"

[tool.isort]
not_skip = "__init__.py"
multi_line_output = 3
include_trailing_comma = true
force_grid_wrap = 0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
-r requirements_tests.txt
bump2version
invoke
isort[pyproject]
isort[pyproject] >= 5.0.0
pylint >= 2.6.0
black
wheel
pep517
Expand Down
9 changes: 4 additions & 5 deletions {{ cookiecutter.project_name }}/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ commands =
[testenv:pylint]
description = Run pylint against the code
deps =
isort[pyproject]
pylint
isort[pyproject] >= 5.0.0
pylint >= 2.6.0
commands =
python -m pylint {posargs:src/{{ cookiecutter.slug_name }}}

Expand Down Expand Up @@ -74,11 +74,10 @@ commands =

[testenv:check_isort]
description = Check sorting of import statements
skip_install = true
deps =
isort[pyproject]
isort[pyproject] >= 5.0.0
commands =
python -m isort -c {posargs:--diff -rc src tests}
python -m isort -c {posargs:--diff src tests}

[testenv:check_black]
description = Check code formatting
Expand Down

0 comments on commit efeca7a

Please sign in to comment.