Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bubt: replace block pools with lockless buffer pool. #67

Closed
prataprc opened this issue Mar 10, 2018 · 2 comments
Closed

bubt: replace block pools with lockless buffer pool. #67

prataprc opened this issue Mar 10, 2018 · 2 comments

Comments

@prataprc
Copy link
Member

prataprc commented Mar 10, 2018

Right now, bubt-flusher maintains a buffer pool via a channel in bubtflusher:blocks. Replace this with a lock-less buffer pool.

Additionally, replace Snapshot.readbuffers channel with lock-less buffer pool.

Also replace Snapshot:viewcache, Snapshot:curcache with lock-less pool.

@prataprc
Copy link
Member Author

After every optimization with lock-less buffer pool use dbperf/mod_bubt* to measure throughput and latency improvements along with CPU-profile (pprof.svg)

@prataprc
Copy link
Member Author

a. replacing bubtflusher:blocks with blockpool.

This does not yield much performance improvements, both build time and memory allocation remains more or less the same. Nevertheless, retaining this implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant