🚀 Suggestions

[EvanBacon]

Great work on this plugin, I'm ecstatic about the progress so far! Below I've outlined some things that you can use (or ignore).

Entry Point

Two possible approaches:

• Custom static entry point like index.clip.js -- this is similar to how React Native used to work with a different index.android.js, and index.ios.js.
• Reuse the default entry point and expose some value like Platform.isAppClip to export a different default component. This is more akin to how universal React works now.

App Icon

We should expose the upstream plugin in @expo/config-plugins but since we don't, you can use this to get all of the dynamic values we support in the app.json icon property (resizing, urls, caching between runs, etc).

Entitlements

Here is an example of adding a safe modifier for the entitlements file, this is good because it means users can easily extend or add values to the template you provide. I also do the same with the custom Info.plist. Ultimately this will scale nicely and help end-users.

It can be used like this.

Further, I recommend using this static value $(AppIdentifierPrefix)$(CFBundleIdentifier) for com.apple.developer.parent-application-identifiers so users can more easily change the bundle identifier. Apple automatically expands this value during code signing. Ref: used this to simplify some other plugins.

Accent Color

Here's an example for adding the accent color the color getter probably doesn't work. For that you can try this helper from react-xib.

Name / Defaults

• Be sure to sanitize the project name, you can use this method (based on a lot of trial/error).
• Since you need to forward the build numbers, they can be retrieved from the config like this.
• Most users don't really care about what their child bundle identifiers are so you could offer a default value like this.

Docs

We added support for running app clips with expo run:ios --scheme a few months ago so this should make development a bit easier. If you find an issue with this workflow please let me know, Xcode is no fun.

---

Again, great work! Excited to follow the progress of this project!

[bndkt]

Thanks for the great suggestions, Evan! I completely agree that having the same entry point and then distinguishing between App Clip or not within the components is more elegant. As this is quite a change to how people implement the plugin, I tackled this one today and already released an update with the new behavior so that people do not get started in the "wrong" direction.

I also added instructions to the docs on how to run using expo run:ios --scheme, which really works like a charm. The only issue seems to be that you have to run the full app one time (without specifying --scheme) before you can run the App Clip. And the Simulator doesn't open the App Clip, you have to go to the home screen in Simulator and open it yourself.

[wkozyra95]

Hi, I would recommend moving that config from extra field into your plugin, it would simplify setup for your users significantly. You can check example of that in e.g. https://github.com/OneSignal/onesignal-expo-plugin/blob/main/support/eas/getEasManagedCredentialsConfigExtra.ts and if you want to support configuring any of those values by users you can just make them arguments of the plugin

[nandorojo]

To echo some suggestions here, I like the idea of putting the extra.eas code config into your plugin's options:

{
  "expo": {
    "name": "my-app",
    "plugins": [
      [
        "react-native-app-clip",
        {
          "name": "My App Clip",
          "extension": {
            "targetName": "my-appClip",
            "bundleIdentifier": "com.example.my-app.Clip",
            "entitlements": {
              "com.apple.developer.parent-application-identifiers": "com.example.my-app",
              "com.apple.developer.on-demand-install-capable": true
            }
          }
        }
      ]
    ]
  }
}

Btw – is it necessary to specify the entitlements there, or should the plug-in do this under the hood?

[bndkt]

@wkozyra95 @nandorojo thanks for your input! This extra config is actually what I'd like to tackle next as it annoys me and I'd like react-native-app-clip to add an App Clip "with one additional line of configuration only". The plugin is actually already generating the extra config automatically inspired by the OneSignal plugin you also mentioned @wkozyra95 - see here. And it is also handling the entitlements internally (see here).

In the simplified tutorial I wrote, this config is actually left out, and running the App Clip in Simulator works fine without it.

BUT: It seems to me this additional configuration is still required right now if you want to build for the App Store. Because it is used by EAS Build to determine which provisioning profiles are required from your Apple Developer account and it seems to me the app config that is injected by the plugin is coming too late for that. I did however just test a little bit again and if I run "expo prebuild" before and then run "eas build", it now which provisioning profiles to use. I'll test a little bit more and report back.

This is how the credentials need to look.

[wkozyra95]

I see, the problem here

react-native-app-clip/src/withAppClipAppConfig.ts

Line 6 in 1f9f1c7

return withDangerousMod(config, [

is that you are doing it inside mod
so those values are not applied if you run e.g. expo config, but if you drop the mod part e.g https://gist.github.com/wkozyra95/d6a769ba09824959837cdd3d146feffc (not tested that) it should work without extra field in app.json

just FYI extra field is not needed for the build itself, it's only there to pass information to eas-cli, so it can generate correct provisioning profiles for all targets

[bndkt]

Ahhh, that simple! Thank you so much @wkozyra95, I just tested it and released 0.0.10 with the fix, where I also removed the now unnecessary extra config from the instructions.

[Noitidart]

This is super cool thanks for this awesome library. I heard Android has something similar called "Instant App"s is that something on mind?

Also is there something as easy as this, to make home screen, and lock screen, widgets on iOS Android? lol this is so awesome, thanks again!