Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[document-picker] Update to use codesigning variables in entitlements #17158

Merged
merged 4 commits into from Apr 23, 2022

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Apr 21, 2022

Why

Utilize the codesigning variables in the entitlements file to dynamically link credentials at build time. [Discovered here](AppIdentifierPrefix is different in main app and extension - https://developer.apple.com/forums/thread/118773?answerId=674983022#674983022). I searched around github and found that others have used this same technique in their iOS projects.

How

Utilize variables $(TeamIdentifierPrefix)$(CFBundleIdentifier)

  • Change process.env.EXPO_APPLE_TEAM_ID -> $(TeamIdentifierPrefix) -(Xcode converts to)-> XXXXXX.
  • Change config.ios.bundleIdentifier -> $(CFBundleIdentifier) -(Xcode converts to)-> foo.bar.app This one didn't work for capability identifier registration.

Test Plan

Resolved entitlements use the correct team ID

Screen Shot 2022-04-23 at 2 12 03 PM

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 21, 2022
EvanBacon and others added 2 commits April 21, 2022 11:56
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 21, 2022
Copy link
Contributor

@bbarthec bbarthec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking solid 👍

@EvanBacon EvanBacon merged commit 3ee85c4 into main Apr 23, 2022
@EvanBacon EvanBacon deleted the @evanbacon/document-picker/plugin-entitlements branch April 23, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants