Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is type 'culprit' not 'Culprit'? #102

Closed
ArcticSnowman opened this issue Sep 20, 2017 · 4 comments
Closed

Why is type 'culprit' not 'Culprit'? #102

ArcticSnowman opened this issue Sep 20, 2017 · 4 comments

Comments

@ArcticSnowman
Copy link
Contributor

Why is type 'culprit' not 'Culprit'?

Seems odd to have a structure type not follow the case rules..

Also it prevent the godoc from showing it in the documentation page and you don't have a nice link from the build.GetCulprits() function definition.
@ArcticSnowman
Copy link
Contributor Author

This in fact breaks the GetCulprits() as you can't pass the return array around as the 'type' is not exported..

@ArcticSnowman
Copy link
Contributor Author

PR #103 to fix

@supereagle
Copy link
Collaborator

Agree.

Seems odd to have a structure type not follow the case rules..
Also it prevent the godoc from showing it in the documentation page and you don't have a nice link from the build.GetCulprits() function definition.

Even culprit is not exported, GetCulprits() also can correctly work.

This in fact breaks the GetCulprits() as you can't pass the return array around as the 'type' is not exported..

@ArcticSnowman
Copy link
Contributor Author

OK fixed with the merge of the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@supereagle @ArcticSnowman