Change culprit to Culprit #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supereagle
reviewed
Oct 6, 2017
logging.go
Outdated
|
|
||
| func Error (message string) { | ||
|
|
||
| log.Printf("ERROR: %s",message) |
There was a problem hiding this comment.
Compared with the old implementation, this can not output info/warning log and error log to different standard files, maybe it is not good enough.
There was a problem hiding this comment.
Opps... Sorry I was moving forward did not mean for it to be part of this PR
|
LGTM |
jernyreverb
pushed a commit
to jernyreverb/gojenkins
that referenced
this pull request
Dec 29, 2017
* Change culprit to Culprit * Update build.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the type 'culprit' to 'Culprit' so that GO exports this type and
build.GetCulprits()us usable in a program.