Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scikitplot: incorrect extra requirement #218

Open
bersbersbers opened this issue Oct 8, 2020 · 2 comments
Open

scikitplot: incorrect extra requirement #218

bersbersbers opened this issue Oct 8, 2020 · 2 comments
Labels

Comments

@bersbersbers
Copy link

user@host:~> mkdir temp
user@host:~> cd temp
user@host:~/temp> echo import scikitplot > bug.py
user@host:~/temp> pipreqs 
INFO: Successfully saved requirements file in /home/bers/temp/requirements.txt
user@host:~/temp> more requirements.txt 
scikit_plot==0.3.7
scikitplot==0.1.1

The last line should not be there.

@squeezer44
Copy link

squeezer44 commented Oct 9, 2020

@bersbersbers
I just tried out your code (to clarify another question) and was not able to reproduce your effect:

user@host:~> mkdir temp
user@host:~> cd temp
user@host:~/temp> echo import scikitplot > bug.py
user@host:~/temp> pipreqs 
INFO: Successfully saved requirements file in /home/bers/temp/requirements.txt

After I opened the requirements.txt I don't see the entry you've mentioned. Only this is in:
scikitplot==0.1.1

@bersbersbers
Copy link
Author

@squeezer44 that is good enough as an example. I'm not sure why you don't get scikit_plot in there - either way, scikitplot is definitely incorrect. See https://pypi.org/project/scikitplot/:

A package to prevent exploit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants