osfile Macro does not create system specifc paths

[juergen-albert]

bnd/biz.aQute.bndlib/src/aQute/bnd/osgi/Macro.java

Line 1474 in 09c46ea

return IO.absolutePath(f);

I'm on Windows and I would expect that ${osfile;test;atest} would produce a path with \ in it, but in IO.absolutPath we finally do this:

bnd/aQute.libg/src/aQute/lib/io/IO.java

Line 817 in 09c46ea

return path.replace(File.separatorChar, '/');

Which makes the whole thing do the opposite of what it should.

[bjhargrave]

In Bnd all paths are forward slash so when macros process them, they don't need to worry.

Windows accepts forward slash in files names, except for the command shell. So we do quoting on windows to handle paths with forward slash.

bnd/aQute.libg/src/aQute/libg/command/Command.java

Lines 95 to 104 in 09c46ea

	if (IO.isWindows()) {
	// [cs] Arguments on windows aren't processed correctly.
	// So we need to perform some escaping.
	// http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6511002
	// http://msdn.microsoft.com/en-us/library/17w5ykft.aspx
	p.command(p.command()
	.stream()
	.map(Command::windowsQuote)
	.collect(toList()));
	}

So, Bnd always uses forward slashed in paths.

[juergen-albert]

Hmm, this does not seem to work for everything. If I try e.g. ${system;mkdir ${osfile;test;atest}} the result is something like mkdir n:/someworkspace/project/test/atest and mkdir complains that the directory is in the wrong format. Using the mkdir n:\someworkspace\project\test\atest however works. The command might be a special case though as other commands work as you say.

[bjhargrave]

I think you are correct here for osfile as its purpose appears to be making os specific paths. c7f942b from 4 years ago is the where I changed this. Let me make a PR to change this back.

[juergen-albert]

Thanks heaps!