New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle conventions are deprecated and scheduled for removal, use extensions instead #5714
Comments
Could you provide a PR since you seem to be deep in the code? |
I was just reading the stack :) I can try to raise a draft, and see if CI is happy with it. |
Hah, I cloned the project, built, set up IDEA only to realize this is already fixed by removing conventions altogether by @bjhargrave in #5453. The reason I didn't find it in my original investigation is because 6.4.1 claims to be a no-plugin release, which is confirmed by not having an artifact in mavenCentral(). Yet the commit of the fixing PR is tagged by 6.4.1, could there be a release of this? |
This seems like an error. That PR should not be part of the 6.4.x stream. |
Forget 6.4.1, I probably should've called it something else. We will be releasing 7.0.0 the coming months |
Ok, so we can call this fixed by #5453 then, available in 7.x only. |
Hello! I'm trying to do a Gradle 8.2 upgrade on the Mockito project. I fixed all other problems stemming from the new deprecation nagging they added in Gradle for conventions. This last one I can't fix because there's no way to avoid calling
t.getConvention()
inBndBuilderPlugin
.I've noticed that
BundleTaskConvention
was migrated toBundleTaskExtension
, butBundleTaskConvention
is still always registered. I would like to request thatt.getConvention().getPlugins().put()
be moved behind a Gradle version check (only call.getConvention()
on Gradle < 8.2). If backwards compatibility needs to be ensured, I recommend a new Gradle property for those still requiring the convention (e.g.biz.aQute.bnd.builder.register-convention=true
ingradle.properties
with a default value of false).See docs: https://docs.gradle.org/8.2/userguide/upgrading_version_8.html#deprecated_access_to_conventions
There are 2 affected code paths:
BndBuilderPlugin configuring Jar task
Bundle task configuring Jar task (super-type)
The text was updated successfully, but these errors were encountered: