Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long SSIDs and passwords cropped on generated document #28

Closed
olekstomek opened this issue Jul 2, 2021 · 4 comments · Fixed by #34
Closed

Long SSIDs and passwords cropped on generated document #28

olekstomek opened this issue Jul 2, 2021 · 4 comments · Fixed by #34
Labels
bug Something isn't working

Comments

@olekstomek
Copy link
Contributor

Max length input network name is 32 characters and I inserted value with 32 characters: abcdefghijklmnopqrstuwxyzabcdefg
Max length input for password is 64 characters and I inserted value with 64 characters: abcdefghijklmnopqrstuwxyzabcdefghijklmnopqrstuwxyzabcdefghijklmn

Generated PDF (📡 WiFi Card.pdf) shows only abcdefghijklmnopqrst for network name and password. So it's only 20 characters, it means that 12 characters are missing for the network name and 44 characters are missing for the password.

@bndw
Copy link
Owner

bndw commented Jul 4, 2021

Hi @olekstomek,

Thanks for the report. Could you provide some repro steps? I have no problem with the full network name:

image

@bndw bndw added the question Further information is requested label Jul 5, 2021
@olekstomek
Copy link
Contributor Author

olekstomek commented Jul 5, 2021

Hi @bndw, I meant what is visible in the generated PDF document. In qr code the data is correct, but the text next to qr code is not correct, because the name of the network and password visible in the PDF is:
abcdefghijklmnopqrst
image
If someone enters the login details in the device manually (without scanning the qr code), it will not connect to the network.

@bndw bndw added bug Something isn't working and removed question Further information is requested labels Jul 5, 2021
@bndw bndw changed the title Incorrect network name and password on generated document Long SSIDs and passwords cropped on generated document Jul 5, 2021
@bndw
Copy link
Owner

bndw commented Jul 5, 2021

Thanks for the clarification on the problem. I don't think the existing design will easily accommodate a 64 character input without either dynamically changing font size or converting inputs to textareas and wrapping.

Out of curiosity -- is this visible character limit impacting your usage or are you simply testing and reporting the bug?

@olekstomek
Copy link
Contributor Author

I am testing it and I found such an extreme case. I assume that hardly anyone has a network name or password greater than 20 characters.

Another solution is either the information when generating the document and on the generated document that it is only part of the network name/password if it exceeds 20 characters and that the qr code should be scanned. And/or the last 3 characters, if there are more than 20 characters, should be replaced with dots, e.g .:
abcdefghijklmnopq...

bndw added a commit that referenced this issue Jul 6, 2021
Issue #28 discovered long ssid and password values would be visibly cropped.
This change replaces the input fields with 2-row textareas that properly
handle the maximum length of both ssids and passwords, 32 and 63 characters
respectively.
@bndw bndw closed this as completed in #34 Jul 6, 2021
bndw added a commit that referenced this issue Jul 6, 2021
Issue #28 discovered long ssid and password values would be visibly cropped.
This change replaces the input fields with 2-row textareas that properly
handle the maximum length of both ssids and passwords, 32 and 63 characters
respectively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants