Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear network.password when "None" encryption mode is selected #46

Closed
bndw opened this issue Jul 15, 2021 · 1 comment · Fixed by #53
Closed

Clear network.password when "None" encryption mode is selected #46

bndw opened this issue Jul 15, 2021 · 1 comment · Fixed by #53
Labels
good first issue Good for newcomers

Comments

@bndw
Copy link
Owner

bndw commented Jul 15, 2021

When selecting "None" encryption, the network.password field remains unchanged. In my testing, the password will actually change the QR code that is generated for None encryption. So assuming that we want to have no password for None encryption, we will need to clear network.password when upon selection of None encryption. Something like this:

setNetwork({ ...network, password: '' })

Originally posted by @noahhefner in #44 (comment)
@bndw bndw mentioned this issue Jul 15, 2021
Closed
@bndw bndw added the good first issue Good for newcomers label Jul 15, 2021
@faithfulnessalamu
Copy link
Contributor

I would like to make a PR to close this

@faithfulnessalamu faithfulnessalamu mentioned this issue Jul 15, 2021
Merged
@noahhefner noahhefner mentioned this issue Jul 16, 2021
Closed
@bndw bndw closed this as completed in #53 Jul 16, 2021
bndw pushed a commit that referenced this issue Jul 16, 2021
Unset password when encryption mode is 'None' (#53)
0b68be6 
* Unset password when encryption mode is 'None'

Fixes #46

* Run code format
@olekstomek olekstomek mentioned this issue Jul 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unset password when encryption mode is 'None' faithfulnessalamu/wifi-card
2 participants
@bndw @faithfulnessalamu