Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #44] Hide password when using "None" encryption #56

Merged
merged 4 commits into from Jul 16, 2021
Merged

[Issue #44] Hide password when using "None" encryption #56

merged 4 commits into from Jul 16, 2021

Conversation

noahhefner
Copy link
Contributor

Resolves issue #44. See demo below.

remove-all-password.mp4

bndw
bndw reviewed Jul 16, 2021
View reviewed changes
Copy link
Owner

@bndw bndw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! Left a comment on the specific implementation, where I think we could simplify it a bit.

src/components/Card.js Outdated Show resolved Hide resolved
bndw
bndw reviewed Jul 16, 2021
View reviewed changes
src/components/Card.js Outdated Show resolved Hide resolved
@noahhefner
Copy link
Contributor Author

noahhefner commented Jul 16, 2021 •
edited

There were a few places where we were double-assigning the className no-print, so I fixed those as well (Hidepassword checkbox and label.)

@noahhefner noahhefner mentioned this pull request Jul 16, 2021
Closed
@bndw bndw merged commit a283fe4 into bndw:master Jul 16, 2021
@noahhefner noahhefner deleted the Issue44-hide-password branch July 16, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bndw bndw bndw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noahhefner @bndw