Add helper method isStaticallyCallable

bnf · Sep 12, 2018 · 48e44c0 · 48e44c0
1 parent d8cf411
commit 48e44c0
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/ServiceProviderCompilationPass.php b/src/ServiceProviderCompilationPass.php
@@ -119,7 +119,7 @@ private function addServiceDefinitionFromCallable($serviceName, $serviceProvider
             $factoryDefinition->setDecoratedService($previousServiceName, $innerName);
         }
 
-        if ((is_array($callable) && is_string($callable[0])) || is_string($callable)) {
+        if ($this->isStaticallyCallable($callable)) {
             $factoryDefinition->setFactory($callable);
         } else {
             $factoryDefinition->setFactory([ new Reference('service_provider_registry_'.$this->registryId), $method ]);
@@ -135,6 +135,11 @@ private function addServiceDefinitionFromCallable($serviceName, $serviceProvider
         $container->setDefinition($finalServiceName, $factoryDefinition);
     }
 
+    private function isStaticallyCallable(callable $callable): bool
+    {
+        return (is_array($callable) && is_string($callable[0])) || is_string($callable);
+    }
+
     private function getReturnType(callable $callable, string $serviceName): string
     {
         return $this->getReflection($callable)->getReturnType() ?: $serviceName;