Allow installation with TYPO3v10 LTS #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The annotations of HTTP classes have been fixed TYPO3 v10 LTS with commit: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61558 Signed-off-by: Benjamin Franzke <benjaminfranzke@gmail.com>
|
Will merge for sure, although the factories are natively available in v10.4, as I upstreamed them in https://review.typo3.org/c/Packages/TYPO3.CMS/+/61558 Still, out of interest: any special usecase that requires this package to be v10.4 compatible? |
|
Yes, I'm currently working on compatibility for TYPO3v10 in https://github.com/pagemachine/typo3-mail-css-inliner which uses your package for tests. It's good if I can keep dependencies unchanged between TYPO3 versions. Also thanks for the quick release. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.