Feat: Make cargo-witgen into lib so that other CLI apps can reuse it #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjjj
approved these changes
Apr 10, 2022
Also `parse_crate_as_file` now returns `File` and adds `parse_file`
bnjjj
reviewed
Apr 10, 2022
Co-authored-by: Coenen Benjamin <benjamin.coenen@hotmail.com>
|
Thanks for the quick review! I addressed most of your issues. I plan to add the AST types this week! |
|
Should I plan a release before the AST stuffs ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new
Witgenstruct that handles generating thewitstring and its output. This way other applications (specifically witme) can use#[clap(flatten)]to inject it into their subcommand.