Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO / Opengraph / Twitter cards #8

Closed
S1SYPHOS opened this issue Mar 8, 2019 · 3 comments
Closed

SEO / Opengraph / Twitter cards #8

S1SYPHOS opened this issue Mar 8, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@S1SYPHOS
Copy link
Contributor

S1SYPHOS commented Mar 8, 2019

Hey there,
great plugin, many thanks are in order - now, it would be great to have an example how you populate SEO / Opengraph meta tags (with custom page methods etc as mentioned in README.md), like you did on your devkit page?

PR regarding some minor fixes is up and running 🍙

// Edit: I'm open to adding twitter card support, too. And what's your standing on og:locale and og:description? being included by default?

Cheers!

@S1SYPHOS S1SYPHOS changed the title SEO / Opengraph SEO / Opengraph / Twitter cards Mar 9, 2019
@bnomei
Copy link
Owner

bnomei commented Mar 11, 2019

about metatags. the code is available but i agree it should be explained in readme.
https://github.com/bnomei/kirby3-plugins.bnomei.com/blob/master/site/plugins/metatags/index.php

i will read up on og:locale and og:description and add them.

you can allways use a custom snippet to add twitter card support. i am not in favor of adding it by default but will add it as unregistered snippet if you PR it.

bnomei added a commit that referenced this issue Mar 11, 2019
Signed-off-by: Bruno Meilick <b@bnomei.com>
@bnomei
Copy link
Owner

bnomei commented Mar 11, 2019

added example to readme.

about og:locale and og:description. they should work whats you issue there?

@bnomei bnomei self-assigned this Mar 11, 2019
@bnomei bnomei added enhancement New feature or request question Further information is requested labels Mar 11, 2019
@bnomei
Copy link
Owner

bnomei commented Sep 1, 2019

@bnomei bnomei closed this as completed Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants