Skip to content

Commit

Permalink
test: mark big string tests flaky on freebsd
Browse files Browse the repository at this point in the history
Some of the addons/stringbytes-external-exceed-max tests are known flaky
after the upgrade to V8 6.2.  The most likely reason is the increase of
the maximum string length from 256 to 1024 MB, pushing their execution
times over the time limit.

Fixes: nodejs#16354
Refs: nodejs#15362
  • Loading branch information
bnoordhuis committed Oct 21, 2017
1 parent 353040c commit ffc04cf
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
10 changes: 10 additions & 0 deletions test/addons/addons.status
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
prefix addons

# https://github.com/nodejs/node/issues/16354 - known flaky after the upgrade
# to V8 6.2 in https://github.com/nodejs/node/pull/15362. Most likely reason
# is the increase of the maximum string length from 256 to 1024 MB, pushing
# their execution times over the time limit.
[$system==freebsd]
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-binary: FLAKY,PASS
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex: FLAKY,PASS
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max: FLAKY,PASS
2 changes: 1 addition & 1 deletion test/addons/testcfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
import testpy

def GetConfiguration(context, root):
return testpy.AddonTestConfiguration(context, root, 'addon')
return testpy.AddonTestConfiguration(context, root, 'addons')

0 comments on commit ffc04cf

Please sign in to comment.