Skip to content
Browse files

child_process: clear .pid property on child exit

This is backwards compatible with the v0.4 branch.
  • Loading branch information...
1 parent c84b3c4 commit d53e0d0298add5b80cbdc6e6bee649c35c13d353 @bnoordhuis committed Mar 7, 2012
Showing with 30 additions and 0 deletions.
  1. +1 −0 lib/child_process.js
  2. +29 −0 test/simple/test-child-process-pid.js
View
1 lib/child_process.js
@@ -377,6 +377,7 @@ function maybeExit(subprocess) {
subprocess._closesGot++;
if (subprocess._closesGot == subprocess._closesNeeded) {
+ subprocess.pid = null; // v0.4 compatibility
subprocess.emit('exit', subprocess.exitCode, subprocess.signalCode);
}
}
View
29 test/simple/test-child-process-pid.js
@@ -0,0 +1,29 @@
+// Copyright Joyent, Inc. and other Node contributors.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the
+// "Software"), to deal in the Software without restriction, including
+// without limitation the rights to use, copy, modify, merge, publish,
+// distribute, sublicense, and/or sell copies of the Software, and to permit
+// persons to whom the Software is furnished to do so, subject to the
+// following conditions:
+//
+// The above copyright notice and this permission notice shall be included
+// in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+// USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+var common = require('../common');
+var assert = require('assert');
+var spawn = require('child_process').spawn;
+
+var child = spawn(process.execPath, [common.fixturesDir + '/empty.js']);
+child.on('exit', function() {
+ assert.equal(child.pid, null);
+});

0 comments on commit d53e0d0

Please sign in to comment.
Something went wrong with that request. Please try again.