Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump kotlinter to 3.14 and ktlint action to 1.5.1 #86

Merged
merged 5 commits into from
Apr 7, 2023

Conversation

christophsturm
Copy link
Contributor

@christophsturm christophsturm commented Apr 3, 2023

this replaces #83

the reformatting is done in a separate commit to make review easier, and enable us to revert it if we want to change code style options

@christophsturm
Copy link
Contributor Author

the lint task now works, but there seems to be a different problem now. I tried updating gradle to 8.0.2, but that triggered a different problem. maybe the best thing is to bump all dependencies and then revisit this pr.

@TWiStErRob
Copy link
Contributor

TWiStErRob commented Apr 3, 2023

I can help with Gradle issues if you share the problem ;) But agree, bump deps first is probably better than solving and bundling more into one PR. Tip: you can remove the kotlinter integration from this PR and just merge the ktlint action, configuration and reformat as one unit. This moves things forward, and future kotlinter PR will be tiny.

@christophsturm
Copy link
Contributor Author

christophsturm commented Apr 3, 2023

This moves things forward, and future kotlinter PR will be tiny.

done!

@christophsturm
Copy link
Contributor Author

christophsturm commented Apr 3, 2023

I can help with Gradle issues if you share the problem ;)

you could do a separate pr that bumps gradle to 8.0.2

@TWiStErRob TWiStErRob mentioned this pull request Apr 4, 2023
@bnorm
Copy link
Owner

bnorm commented Apr 6, 2023

Now that #87 has been merged, will we be able to leave the kotlinter plugin enabled?

@christophsturm
Copy link
Contributor Author

Now that #87 has been merged, will we be able to leave the kotlinter plugin enabled?

no, because it still fails. the fix seems to be in kotlin 1.8, and that needs api changes. So i would keep kotlinter disabled while we still support kotlin 1.7.
I made a new kotlin 1.8.2 pr to check that it will work with 1.8.2 here: #89

@bnorm bnorm merged commit 87b209a into bnorm:master Apr 7, 2023
@bnorm
Copy link
Owner

bnorm commented Apr 7, 2023

Thanks for this! I'm going to try and release a new version today so we can also get #89 merged and released as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants