Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 8 #87

Merged
merged 12 commits into from
Apr 6, 2023
Merged

Gradle 8 #87

merged 12 commits into from
Apr 6, 2023

Commits on Apr 4, 2023

  1. Fix deprecation warning in KAPT

    > Task :kotlin-power-assert-plugin:kaptTestKotlin
    Annotation processors discovery from compile classpath is deprecated.
    Set 'kapt.include.compile.classpath=false' to disable discovery.
    TWiStErRob committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    51972d8 View commit details
    Browse the repository at this point in the history
  2. Fix kotlinc warning in InfixFunctionTest

    > Task :kotlin-power-assert-plugin:compileTestKotlin
    w: P:\projects\contrib\github-kotlin-power-assert\kotlin-power-assert-plugin\src\test\kotlin\com\bnorm\power\InfixFunctionTest.kt: (357, 9): Name shadowed: main
    TWiStErRob committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    f50fc5e View commit details
    Browse the repository at this point in the history
  3. Fix kotlinc warning in PowerAssertCallTransformer

    > Task :kotlin-power-assert-plugin:compileKotlin
    w: P:\projects\contrib\github-kotlin-power-assert\kotlin-power-assert-plugin\src\main\kotlin\com\bnorm\power\PowerAssertCallTransformer.kt: (174, 77): Name shadowed: newVariables
    TWiStErRob committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    89a697c View commit details
    Browse the repository at this point in the history
  4. Fix Gradle 8 breaking change, add dependency between tasks.

    > Task :kotlin-power-assert-gradle:publishPluginJar
    Execution optimizations have been disabled for task ':kotlin-power-assert-gradle:publishPluginJar' to ensure correctness due to the following reasons:
      - Gradle detected a problem with the following location: 'P:\projects\contrib\github-kotlin-power-assert\kotlin-power-assert-gradle\build\generated\source\buildConfig\main\main'. Reason: Task ':kotlin-power-assert-gradle:publishPluginJar' uses this output of task ':kotlin-power-assert-gradle:generateBuildConfig' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.4.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.
    Gradle detected a problem with the following location: 'P:\projects\contrib\github-kotlin-power-assert\kotlin-power-assert-gradle\build\generated\source\buildConfig\main\main'. Reason: Task ':kotlin-power-assert-gradle:publishPluginJar' uses this output of task ':kotlin-power-assert-gradle:generateBuildConfig' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.4.2/userguide/validation_problems.html#implicit_dependency for more details about this problem. This behaviour has been deprecated and is scheduled to be removed in Gradle 8.0. Execution optimizations are disabled to ensure correctness. See https://docs.gradle.org/7.4.2/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
    TWiStErRob committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    eb3096c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e88aecd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3379d5a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fc56e0c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9ae0ac3 View commit details
    Browse the repository at this point in the history
  9. Upgrade plugin-publish to latest 1.1.0

    Action "Deprecate the entire `pluginBundle` block when using Gradle version 7.6 or later,
            mark for removal in version 8.0" from https://plugins.gradle.org/plugin/com.gradle.plugin-publish/1.0.0-rc-3
    
    Gradle publishing has to execute publishPlugins directly, because the new version already applies the Maven Publish Plugin, that creates the task "publish", which publishes to registered repositories only.
    TWiStErRob committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    5324850 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e35e4d8 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    489e478 View commit details
    Browse the repository at this point in the history
  12. Downgrade Gradle in sample project because of removed outdated API (d…

    …etails below), assuming Kotlin 1.7 to 1.8 bump is not wanted yet.
    
    * What went wrong:
    Failed to notify task execution graph listener.
    > org.gradle.api.reporting.DirectoryReport.setEnabled(Z)V
    
    Caused by: java.lang.NoSuchMethodError: org.gradle.api.reporting.DirectoryReport.setEnabled(Z)V
            at org.jetbrains.kotlin.gradle.testing.internal.KotlinTestReport.disableTestReporting(KotlinTestReport.kt:242)
    
    https://github.com/JetBrains/kotlin/blob/v1.7.0/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/testing/internal/KotlinTestReport.kt#L242
    
    Gradle 8.0 removed that deprecated property:
    https://docs.gradle.org/current/userguide/upgrading_version_7.html#report_and_testreport_api_cleanup
    
    Fixed in Kotlin 1.8.0: JetBrains/kotlin@e902ae7
    
    Deprecation warnings in sample project are all related to this, run: `sample$ gradlew build --warning-mode=all` for more info.
    TWiStErRob committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    85c1b08 View commit details
    Browse the repository at this point in the history