Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix all abort / exit / stderr / stdout statements #1

Closed
jwijffels opened this issue Dec 11, 2022 · 2 comments
Closed

fix all abort / exit / stderr / stdout statements #1

jwijffels opened this issue Dec 11, 2022 · 2 comments

Comments

@jwijffels
Copy link
Contributor

No description provided.

jwijffels added a commit that referenced this issue Dec 12, 2022
@jwijffels
#1 remove abort
3692b16
jwijffels added a commit that referenced this issue Dec 12, 2022
@jwijffels
#1 fprintf > Rprintf and printf > Rprintf, remove stderr
d85a9b6
jwijffels added a commit that referenced this issue Dec 12, 2022
@jwijffels
#1 fflush(stdout) > Rcpp::checkUserInterrupt();
1e0784d
jwijffels added a commit that referenced this issue Dec 12, 2022
@jwijffels
#1 fprintf > Rf_error
d686f98
jwijffels added a commit that referenced this issue Dec 12, 2022
@jwijffels
#1 printf > Rprintf
ad85713
@ggerganov
Copy link

I think you can make this change simpler via macros.
For example, you can put this near the top of the file to avoid all fprintf > Rprintf changes:

#define fprintf(dummy, ...) Rprintf(__VA_ARGS__)

@jwijffels
Copy link
Contributor Author

Thanks for looking upstream in this repository. I'll take your advice on the macro's so that upgrading to another release of whisper.cpp will be more easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwijffels @ggerganov