Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when subset RNA assay stored on-disk #65

Closed
nimanouri-nn opened this issue Jan 12, 2024 · 3 comments
Closed

Error when subset RNA assay stored on-disk #65

nimanouri-nn opened this issue Jan 12, 2024 · 3 comments

Comments

@nimanouri-nn
Copy link

Hello BPCells,

I was wondering if you could please take a look at my issue regarding Seurat or possibly BPCells. I am not certain which one it relates to more, but your advice would be greatly appreciated.

@bnprks
Copy link
Owner

bnprks commented Jan 12, 2024

Thanks for linking this issue. At the very least the misspelled error message is mine :) (Should say "Col" not "Cow").

I did just make some changes to the subsetting logic in BPCells, which is a good candidate for what might be causing this bug. However, I've been unable to reproduce the error with some initial attempts on my end.

Is there any chance you could put together a reproducible example? See here for a good example of using Seurat's demo pbmc3k dataset to hit an issue. You might consider "merging" pbmc3k with itself once to simulate your multi-sample dataset.

A second-best option would be if you can share the code that you're using to process your dataset, which might provide some clues of how to hit this error.

Once I can reproduce the error on my end, I'll be able to much more easily poke around in the object internals to see where things are going wrong. I strongly suspect that this error is not caused by the fact your data was stored on disk, but is some intermediate bug in BPCells triggered by the way the data was handled in Seurat.

bnprks added a commit that referenced this issue Jan 12, 2024
This bug would cause subsets of the first N rows/cols of a
matrix to be ignored improperly in at least some circumstances.
@bnprks
Copy link
Owner

bnprks commented Jan 12, 2024

Actually, I think I just found and fixed a likely culprit for this bug. I've now pushed an updated version of BPCells to github -- would you try reinstalling BPCells and check if that's fixed your issue now?

@nimanouri-nn
Copy link
Author

You are the one! Thanks for the prompt fix. It's working properly now.

@bnprks bnprks closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants