Better JSON-Schema output for Decimal
#692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-kklein
approved these changes
Jan 14, 2024
| """ | ||
| json_schema = self.str_schema(core_schema.str_schema()) | ||
| if self.mode == "validation": | ||
| json_schema["format"] = "decimal" |
There was a problem hiding this comment.
nur aus interesse: was macht den der standard schema generator von Pydantic draus und warum funktioniert das nicht? ggf. könnte man ja auch ein issue bei pydantic aufmachen um das langfristig da zu beheben?
There was a problem hiding this comment.
Pydantic macht quasi ein Union[string, float] draus, was ich ein wenig merkwürdig finde. Wenn du magst, kann ich da ja mal zumindest mal als Nachfrage ein Ticket erstellen.
Co-authored-by: konstantin <konstantin.klein@hochfrequenz.de>
This was referenced Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.