Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build out sorting functionality feature to conformance page #151

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Apr 17, 2024

Related to #148

Currently makes adjustments to allow sorting alphabetically and reverse alpha.

There's probably a little more styling needed on the mobile side of things, but I thought I'd throw this up early for feedback. 😄

@nekevss nekevss requested a review from a team April 17, 2024 00:10
@nekevss nekevss marked this pull request as ready for review April 23, 2024 00:29
@nekevss nekevss mentioned this pull request Apr 23, 2024
7 tasks
@nekevss nekevss changed the title Build out conformance functionality Build out sorting functionality feature to conformance page Apr 23, 2024
@nekevss
Copy link
Member Author

nekevss commented Apr 23, 2024

There are now a whole host of sorting options 😄

@jedel1043
Copy link
Member

Was testing the functionality and I found some bugs:

  • Some ordering options don't work:
    image
    image
  • The selected sort option is not preserved after clicking a suite or the breadcrumbs.

However, I think we can merge this as it is, and open some separate issues for those.

@nekevss
Copy link
Member Author

nekevss commented Apr 24, 2024

This is going to need a rebase after #155 for the fix, and the behavior should be easy to fix for the above.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :)

@jedel1043 jedel1043 merged commit a4d2683 into main Apr 24, 2024
1 check passed
@jedel1043 jedel1043 deleted the add-nav-features branch April 24, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants