(fix) set property size to 0

boa-dev · Sep 10, 2021 · 5906c58 · 5906c58
1 parent df87659
commit 5906c58
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/boa/src/builtins/map/mod.rs b/boa/src/builtins/map/mod.rs
@@ -364,16 +364,17 @@ impl Map {
         // 4. For each Record { [[Key]], [[Value]] } p of entries, do
         // a. Set p.[[Key]] to empty.
         // b. Set p.[[Value]] to empty.
+        Self::set_size(this, 0);
         if let Some(object) = this.as_object() {
             if let Some(map) = object.borrow_mut().as_map_mut() {
                 map.clear();
-                Ok(JsValue::undefined())
             } else {
-                context.throw_type_error("'this' is not a Map")
+                return context.throw_type_error("'this' is not a Map");
             }
         } else {
-            context.throw_type_error("'this' is not a Map")
+            return context.throw_type_error("'this' is not a Map");
         }
+        Ok(JsValue::undefined())
     }
 
     /// `Map.prototype.has( key )`

diff --git a/boa/src/builtins/map/ordered_map.rs b/boa/src/builtins/map/ordered_map.rs
@@ -143,7 +143,7 @@ impl<V> OrderedMap<V> {
     }
 
     pub fn clear(&mut self) {
-        self.map = IndexMap::new();
+        self.map.truncate(0);
     }
 
     /// Return a reference to the value stored for `key`, if it is present,