PR feedback

boa/examples/classes.rs

@@ -1,8 +1,13 @@
-use boa::builtins::object::{Class, ClassBuilder};
-use boa::builtins::value::*;
-use boa::exec::*;
-use boa::realm::Realm;
-use boa::*;
+use boa::{
+    builtins::{
+        object::{Class, ClassBuilder},
+        value::Value,
+    },
+    exec::Interpreter,
+    forward_val,
+    realm::Realm,
+    Result,
+};
 
 use gc::{Finalize, Trace};
 

boa/src/builtins/object/mod.rs

@@ -72,7 +72,7 @@ pub trait Class: NativeObject + Sized {
     /// The amount of arguments the class `constructor` takes, default is `0`.
     const LENGTH: usize = 0;
     /// The attibutes the class will be binded with, default is `writable`, `enumerable`, `configurable`.
-    const ATTRIBUTE: Attribute = Attribute::ALL;
+    const ATTRIBUTE: Attribute = Attribute::all();
 
     /// The constructor of the class.
     fn constructor(this: &Value, args: &[Value], ctx: &mut Interpreter) -> Result<Self>;

boa/src/builtins/property/attribute/mod.rs

@@ -17,12 +17,6 @@ bitflags! {
     /// Additionaly there are flags for when the flags are defined.
     #[derive(Finalize)]
     pub struct Attribute: u8 {
-        /// None of the flags are present.
-        const NONE = 0b0000_0000;
-
-        /// All the flags set (`WRITABLE`, `ENUMERABLE`, `CONFIGURABLE`).
-        const ALL = 0b0011_1111;
-
         /// The `Writable` attribute decides whether the value associated with the property can be changed or not, from its initial value.
         const WRITABLE = 0b0000_0011;
 

boa/src/builtins/property/mod.rs

@@ -71,7 +71,7 @@ impl Property {
     #[inline]
     pub fn empty() -> Self {
         Self {
-            attribute: Attribute::NONE,
+            attribute: Attribute::empty(),
             value: None,
             get: None,
             set: None,