Skip to content

Commit

Permalink
Improve tester display for multiple editions (#2720)
Browse files Browse the repository at this point in the history
This Pull Request improves our test results display per edition and cleanups our edition detector logic.

It changes the following:

- Adds a new `edition` flag to limit the maximum edition that will be tested.
- Adds a new `versioned` flag to display all tested editions in a table.
- Adds utility methods to `SpecEdition` to detect the edition of a test and get all the available editions.
- Cleanups logic.

Output with this PR ~(We only collect ES5, ES6 and ES13 stats, so all other editions are a WIP)~:

![image](https://user-images.githubusercontent.com/38230983/227010384-883f0934-47be-4be7-84c2-a21feb9de8a9.png)

~Marking as a draft since I need to determine the version of the remaining features, but feel free to review everything else.~ Finished!
  • Loading branch information
jedel1043 committed Mar 22, 2023
1 parent d2dd121 commit 9b53859
Show file tree
Hide file tree
Showing 7 changed files with 771 additions and 218 deletions.
69 changes: 69 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion boa_tester/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ fxhash = "0.2.1"
rayon = "1.7.0"
toml = "0.7.3"
color-eyre = "0.6.2"
phf = { version = "0.11.1", features = ["macros"] }
comfy-table = "6.1.4"

[features]
default = ["intl"]
intl = ["boa_engine/intl"]
intl = ["boa_engine/intl"]

0 comments on commit 9b53859

Please sign in to comment.