Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js prefix for JavaScript rust types #1376

Closed
HalidOdat opened this issue Jun 29, 2021 · 5 comments
Closed

Js prefix for JavaScript rust types #1376

HalidOdat opened this issue Jun 29, 2021 · 5 comments
Assignees
Labels
API discussion Issues needing more discussion technical debt
Milestone

Comments

@HalidOdat
Copy link
Member

HalidOdat commented Jun 29, 2021

JsValue <= Value (#1457)
JsString <= RcString (#1380)
JsBigInt <= RcBigInt (#1408)
JsSymbol <= RcSymbol (#1382)
JsObject <= GcObject (#1489)
JsResult <= boa::Result (#1493)

@HalidOdat HalidOdat added technical debt discussion Issues needing more discussion API labels Jun 29, 2021
@HalidOdat HalidOdat self-assigned this Jun 29, 2021
@raskad
Copy link
Member

raskad commented Jun 30, 2021

I think that would be a great change to make things more clear.

@bartlomieju
Copy link
Contributor

@HalidOdat is changing Value to JsValue still desired? I could look into it, looks like fun with so many occurrences.

@HalidOdat
Copy link
Member Author

@HalidOdat is changing Value to JsValue still desired? I could look into it, looks like fun with so many occurrences.

Yes. I'll change in it and create a new PR, I was doing this and #1373 at the same time that's why I did not create a PR for it. But I think it's best to rename it in a separate PR instead of doing both in one PR.

@HalidOdat HalidOdat added this to the v0.13.0 milestone Aug 12, 2021
@jedel1043
Copy link
Member

Is there any other type we would want to rename?

@Razican
Copy link
Member

Razican commented Sep 8, 2021

Is there any other type we would want to rename?

I think it's done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API discussion Issues needing more discussion technical debt
Projects
None yet
Development

No branches or pull requests

5 participants