Custom JavaScript string rust type #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
technical debt
execution
Test262 conformance changes:
|
Razican
reviewed
Jun 30, 2021
Benchmark for 036a20fClick to view benchmark
|
Benchmark for 7a64912Click to view benchmark
|
Benchmark for e1af1cdClick to view benchmark
|
|
There seems to be an overall nice increase in performance :) |
|
@HalidOdat just wondering why there should be this strong of a performance improvement, as I'd expect the memory usage to decrease, but due to heap allocations and deallocations being slower than stack shouldn't it have the adverse effect on the runtime? |
|
Benchmark for 86883f9Click to view benchmark
|
- Moved src/value/rcstring.rs => src/string.rs
Benchmark for fa9197fClick to view benchmark
|
Benchmark for b2e955dClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #1377 .
As per #1376
RcStringhas been renamed toJsString.This is similar to
Rc<str>. But unlikeRc<str>which stores the length on the stack and a pointer to the data TheJsStringlength and data is stored on the heap. (Rc<str>keeps refcount on the heap anyway) and just an non-null pointer is kept on the stack, so its size is the size of a pointer.Also added
JsString::concat(x, y)function, so we don't have to doJsString::new(format!("{}{}", x, y))which wastes an allocation.Moved
src/value/rcstring.rs=>src/string.rs(likesymbol.rs)Reexport
JsStringto root level (because its such a common import, likeValue)This should unblock #1373 :)