Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom JavaScript string rust type #1377

Closed
HalidOdat opened this issue Jun 30, 2021 · 0 comments · Fixed by #1380
Closed

Custom JavaScript string rust type #1377

HalidOdat opened this issue Jun 30, 2021 · 0 comments · Fixed by #1380
Assignees
@HalidOdat
Labels
execution Issues or PRs related to code execution technical debt
Milestone
v0.13.0

Comments

@HalidOdat
Copy link
Member

The current JavaScript string rust (RcString which holds a Rc<str>) is 16 bytes this is because it stores the pointer to the data and length on the stack. And this prevents #1373 from being implemented. So we need to write a custom string type which is referenced counted like Rc<str> and holds the length on the heap.

I should almost be done with this, and I'll create a PR soon :)
@HalidOdat HalidOdat added technical debt execution Issues or PRs related to code execution labels Jun 30, 2021
@HalidOdat HalidOdat self-assigned this Jun 30, 2021
@HalidOdat HalidOdat mentioned this issue Jun 30, 2021
Merged
@Razican Razican added this to the v0.13.0 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HalidOdat HalidOdat

Labels
execution Issues or PRs related to code execution technical debt
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging a pull request may close this issue.

Custom JavaScript string rust type boa-dev/boa
2 participants
@Razican @HalidOdat