Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Cargo Workspaces for publishing #2001

Closed
jasonwilliams opened this issue Apr 3, 2022 · 2 comments
Closed

Use Cargo Workspaces for publishing #2001

jasonwilliams opened this issue Apr 3, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone
v0.15.0

Comments

@jasonwilliams
Copy link
Member

We should setup Cargo Workspaces for publishing next time around similar to rust analzyer
@jasonwilliams jasonwilliams added the enhancement New feature or request label Apr 3, 2022
@jasonwilliams jasonwilliams added this to the v0.15.0 milestone Apr 3, 2022
@jasonwilliams
Copy link
Member Author

jasonwilliams commented Apr 6, 2022 •
edited

Looks like we will need to add publish = false to some packages, but have cargo workspaces still bump the versions on them.

Also we may want to move them into the crates folder like RA have done

@jasonwilliams jasonwilliams mentioned this issue Apr 12, 2022
Closed
bors bot pushed a commit that referenced this issue Apr 26, 2022
@jasonwilliams
cargo workspaces fixes #2001 (#2026)
01bd50f 
This adds cargo-workspaces to our repo for easier publishing. 
(I think we may need to do a dry run of this first to test)

fixes #2001
@Razican
Copy link
Member

Razican commented Jun 1, 2022

This should be fixed, let's reopen if that's not the case.

@Razican Razican closed this as completed Jun 1, 2022
Razican pushed a commit that referenced this issue Jun 8, 2022
@jasonwilliams @Razican
cargo workspaces fixes #2001 (#2026)
5c71f90 
This adds cargo-workspaces to our repo for easier publishing. 
(I think we may need to do a dry run of this first to test)

fixes #2001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - cargo workspaces fixes #2001 jasonwilliams/boa
2 participants
@Razican @jasonwilliams