Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement global Infinity property #480

Closed
HalidOdat opened this issue Jun 11, 2020 · 3 comments · Fixed by #499
Closed

Implement global Infinity property #480

HalidOdat opened this issue Jun 11, 2020 · 3 comments · Fixed by #499
Labels
builtins PRs and Issues related to builtins/intrinsics E-Easy Easy enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@HalidOdat
Copy link
Member

HalidOdat commented Jun 11, 2020

ECMASCript feature

Infinity is not a number, but a global property.

We can add this by adding a new module like NaN https://github.com/boa-dev/boa/tree/master/boa/src/builtins/nan and then adding it to the builtin init function in builtins/mod.rs the value it should contain should be Value::from(f64::INFINITY)

More information
- ECMAScript reference
- MDN

@HalidOdat HalidOdat added enhancement New feature or request good first issue Good for newcomers E-Easy Easy builtins PRs and Issues related to builtins/intrinsics labels Jun 11, 2020
@AnirudhKonduru
Copy link
Contributor

@HalidOdat Can I take this up along with #481 ?

@HalidOdat
Copy link
Member Author

@HalidOdat Can I take this up along with #481 ?

You can have this, I'm not sure about the second though, I think @croraf is doing it. If you need any help or have a question tell us :)

@AnirudhKonduru
Copy link
Contributor

@HalidOdat Can I take this up along with #481 ?

You can have this, I'm not sure about the second though, I think @croraf is doing it. If you need any help or have a question tell us :)

Oh ok, thanks! In that case I'll leave out the changes meant of #481 for the time-being

AnirudhKonduru added a commit to AnirudhKonduru/boa that referenced this issue Jun 16, 2020
AnirudhKonduru added a commit to AnirudhKonduru/boa that referenced this issue Jun 16, 2020
AnirudhKonduru added a commit to AnirudhKonduru/boa that referenced this issue Jun 16, 2020
AnirudhKonduru added a commit to AnirudhKonduru/boa that referenced this issue Jun 16, 2020
AnirudhKonduru added a commit to AnirudhKonduru/boa that referenced this issue Jun 16, 2020
@Razican Razican added this to the v0.9.0 milestone Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics E-Easy Easy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants