Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement coalescing (?? and ??=) #1013

Merged
merged 2 commits into from Dec 31, 2020
Merged

Implement coalescing (?? and ??=) #1013

merged 2 commits into from Dec 31, 2020

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Dec 31, 2020

This Pull Request fixes/closes #1012.

It changes the following:

  • Lexing of ?? and ??=
  • Parsing of logical expressions
  • Execution of ?? and ??=

@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #1013 (d3d4acb) into master (6f3641d) will increase coverage by 0.01%.
The diff coverage is 56.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
+ Coverage   59.83%   59.85%   +0.01%     
==========================================
  Files         167      167              
  Lines       11018    11088      +70     
==========================================
+ Hits         6593     6637      +44     
- Misses       4425     4451      +26     
Impacted Files Coverage Δ
boa/src/syntax/ast/op.rs 10.98% <0.00%> (-0.25%) ⬇️
boa/src/syntax/ast/punctuator.rs 6.00% <0.00%> (-0.25%) ⬇️
boa/src/syntax/lexer/mod.rs 66.66% <0.00%> (ø)
boa/src/syntax/ast/node/operator/bin_op/mod.rs 68.50% <41.66%> (-1.50%) ⬇️
boa/src/syntax/parser/expression/mod.rs 81.89% <68.00%> (-10.65%) ⬇️
boa/src/syntax/lexer/operator.rs 70.17% <72.72%> (+0.61%) ⬆️
...syntax/parser/expression/assignment/conditional.rs 85.00% <100.00%> (ø)
...ntax/parser/expression/left_hand_side/arguments.rs 63.15% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3641d...d3d4acb. Read the comment docs.

@Lan2u Lan2u merged commit 23bc476 into boa-dev:master Dec 31, 2020
@tofpie tofpie deleted the coalescing branch December 31, 2020 21:56
@Razican Razican added this to the v0.11.0 milestone Jan 1, 2021
@Razican Razican added the enhancement New feature or request label Jan 1, 2021
@Razican
Copy link
Member

Razican commented Jan 1, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,493 78,493 0
Passed 19,787 19,824 +37
Ignored 15,585 15,585 0
Failed 43,121 43,084 -37
Panics 396 396 0
Conformance 25.21 25.26 +0.05%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement coalescing
4 participants