Make Array.prototype.concat spec compliant
#1353
Merged
Commits on Jul 22, 2021
-
- adds limit checks to array concat - still fails test/built-ins/Array/prototype/concat/arg-length-exceeding-integer-limit.js - no longer runs forever Closes boa-dev#1306 add `is_concat_spreadable` utility add array check make suggested changes perf add docs & propagate error add `is_concat_spreadable` utility add array check add `is_concat_spreadable` utility add array check make suggested changes fix(boa): fixes concat limit - adds limit checks to array concat - still fails test/built-ins/Array/prototype/concat/arg-length-exceeding-integer-limit.js - no longer runs forever Closes boa-dev#1306 add `is_concat_spreadable` utility add array check make suggested changes perf add docs & propagate error add docs & propagate error
Commits on Jul 24, 2021
Commits on Jul 27, 2021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.