Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(boa): fixes panic on bigint size #1415

Merged
merged 3 commits into from
Aug 21, 2021
Merged

fix(boa): fixes panic on bigint size #1415

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47276a5
fix(boa): fixes panic on bigint size
neeldug Jul 19, 2021
54d638b
fmt
neeldug Jul 25, 2021
2f285b2
order swap
neeldug Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions boa/src/bigint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,15 @@ impl JsBigInt {
return Err(context.construct_range_error("BigInt negative exponent"));
};

let num_bits = (x.inner.bits() as f64
* y.to_f64().expect("Unable to convert from BigUInt to f64"))
.floor()
+ 1f64;

if num_bits > 1_000_000_000f64 {
return Err(context.construct_range_error("Maximum BigInt size exceeded"));
}

Ok(Self::new(x.inner.as_ref().clone().pow(y)))
}

Expand Down